[RFC PATCH v2 2/4] net: ethernet: xilinx: Add gmii2rgmii converter support

Hi Nicolas,

quoted

#ifdef CONFIG_NET_VENDOR_XILINX

You may need to have:
#if defined(CONFIG_NET_VENDOR_XILINX) &&
defined(CONFIG_XILINX_GMII2RGMII)

quoted

 extern int gmii2rgmii_phyprobe(struct gmii2rgmii *xphy); #else extern
void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy);

No need for the line above...

quoted

void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy) { }

On one single line, like:

static inline void gmii2rgmii_phyprobe(struct gmii2rgmii *xphy) { }

quoted

#endif
For me the changes are looking odd...

For me, it's okay...

Ok will fix as you suggested...

quoted

Other possible ways
	1)  Put a config check around phyprobe api in the macb driver.
#ifdef CONFIG_XILINX_GMII2RGMII
                       gmii2rgmii_phyprobe(&bp->converter_phy);
#endif

Nope!

quoted

	2) Select NET_VENDOR_XILINX in the macb Kconfig @ -22,6 +22,7 @@
config MACB
        tristate "Cadence MACB/GEM support"
        depends on HAS_DMA
        select PHYLIB
+       select NET_VENDOR_XILINX

quoted

Please let me know which one you prefer will fix that and will post v3...

First one with my changes is the best. But maybe wait for more feedback...

Ok sure will wait and will post next version with your suggestion in case of no comments...

Regards,
Kedar.

Bye,
--
Nicolas Ferre