Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-29
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH v2] ARM: s3c64xx: Add missing head file

From: Krzysztof Kozlowski <hidden>
Date: 2016-06-29 08:29:35

On 06/29/2016 10:10 AM, Kefeng Wang wrote:
The building reports warning after patch "arm: Remove unnecessary
of_platform_populate with default match table",

"arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list"

Add the missing of.h for device_node struct in common.h, and kill common.h
from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c, because no function need it.

Reported-by: kbuild test robot <redacted>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kefeng Wang <redacted>
---

Hi Krzysztof, 

Thanks for your points, add "Reported-by" tag in v2, and Rob can directly
pick it up if necessary.

Thanks,
Kefeng

 arch/arm/mach-s3c64xx/common.h          | 1 +
 arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help