[RFC PATCH 6/8] PM / Domains: Remove a provider by referencing the data pointer
From: jonathanh@nvidia.com (Jon Hunter)
Date: 2016-06-21 14:45:09
Also in:
linux-pm, linux-tegra
On 04/03/16 11:23, Jon Hunter wrote:
quoted hunk ↗ jump to hunk
To remove a PM domain from the system, it is necessary to ensure that any PM domain providers associated with the PM domain have been removed. Otherwise it could be possible to obtain a pointer to a PM domain structure that has been removed. PM domains now have a reference to the pointer for the PM domain provider's data variable. Add a function so that a PM domain can remove a PM domain provider by referencing the data pointer. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/base/power/domain.c | 24 ++++++++++++++++++++++++ include/linux/pm_domain.h | 2 ++ 2 files changed, 26 insertions(+)diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 72055fef6256..438885f2455f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c@@ -1738,6 +1738,30 @@ void of_genpd_del_provider(struct device_node *np) EXPORT_SYMBOL_GPL(of_genpd_del_provider); /** + * of_genpd_del_provider_by_data() - Remove a registered PM domain provider + * @data: Pointer to the data associated with the PM domain provider + * + * Look up a PM domain provider based upon a pointer to it's data and + * remove the PM domain provider from the list of providers. + */ +void of_genpd_del_provider_by_data(void *data) +{ + struct of_genpd_provider *c, *cp; + + mutex_lock(&of_genpd_mutex); + list_for_each_entry_safe(cp, c, &of_genpd_providers, link) { + if (cp->data == data) { + list_del(&cp->link); + of_node_put(cp->node); + kfree(cp); + break; + } + } + mutex_unlock(&of_genpd_mutex);
On further the thought I believe that the above does not need to be safe variant of list_for_each_entry because we are breaking out of the loop when we find the one we are looking for. of_genpd_del_provider() does the same. Cheers Jon -- nvpublic