[PATCH 7/8] arm64: pmu: Enable multiple PMUs in an ACPI system

Jeremy Linton [off-list ref] writes:

Hi Punit,

On 06/20/2016 11:37 AM, Punit Agrawal wrote:

quoted

Jeremy Linton [off-list ref] writes:

quoted

Its possible that an ACPI system has multiple CPU types in it
with differing PMU counters. Use the newly provided acpi_pmu routines
to detect that case, and instantiate more than one set of counters.

Signed-off-by: Jeremy Linton <redacted>
---
  drivers/perf/arm_pmu.c      |  7 +++-
  drivers/perf/arm_pmu_acpi.c | 98 ++++++++++++++++++++-------------------------
  2 files changed, 50 insertions(+), 55 deletions(-)

[...]

quoted

quoted

@@ -47,7 +52,7 @@ void __init arm_pmu_parse_acpi(int cpu, struct acpi_madt_generic_interrupt *gic)
  }

  /* Count number and type of CPU cores in the system. */
-void __init arm_pmu_acpi_determine_cpu_types(struct pmu_types *pmus)
+static void __init arm_pmu_acpi_determine_cpu_types(struct pmu_types *pmus)
  {
  	int i, j;

Please move this and the following two hunks to the previous patch where you
introduce the functions.

Oh, I did this on purpose to avoid:

"warning: 'xxx' defined but not used" messages.

In that case, I'd suggest merging the patches. IMO, it's better to have
self-contained patches be they slightly large than to introduce
artifacts like here.

quoted

quoted

@@ -74,7 +79,7 @@ void __init arm_pmu_acpi_determine_cpu_types(struct pmu_types *pmus)
   * Registers the group of PMU interfaces which corrispond to the 'last_cpu_id'.
   * This group utlizes 'count' resources in the 'res'.
   */
-int __init arm_pmu_acpi_register_pmu(int count, struct resource *res,
+static int __init arm_pmu_acpi_register_pmu(int count, struct resource *res,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel