On 13/05/16 09:57, Geert Uytterhoeven wrote:

Hi Vladimir,

On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
[off-list ref] wrote:

quoted

On 10/05/16 19:56, Geert Uytterhoeven wrote:

quoted

Enabling support for the UART on the ARM MPS2 platform only make sense
when compiling for the ARM MPS2 platform, unless compile-testing.

What you said is true, but looking around (see SERIAL_STM32 for example)
I'm wondering what makes MPS2 so special flake?

Nothing. SERIAL_STM32 should be fixed, too.
I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.

quoted

I was under impression that architecture/board specific guard must have
only if we have something like

#include <asm/xyz.h>

or

#include <mach/xyz.h>

which is not a case for device-tree driven MPS2 uart.

I have no idea what is practice for such things, so would be grateful to
get it known.

That's why there's an "|| COMPILE_TEST" in the dependency.

First of all sorry for the late response...

Secondly, I have no strong opinion on the patch, so I'd leave the final
word to Greg

FWIW

Reviewed-by: Vladimir Murzin <redacted>

Cheers
Vladimir

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds