On Fri, Jun 03, 2016 at 11:36:33AM +0100, Russell King - ARM Linux wrote:

On Fri, Jun 03, 2016 at 10:40:48AM +0100, Liviu Dudau wrote:

quoted

On Fri, Jun 03, 2016 at 08:58:10AM +0100, Russell King wrote:

quoted

Convert DT component matching to use component_match_add_release().

Hi Russell,

Any reason for not keeping the component_match_add() calls in the drivers?

Sorry, I don't understand your comment.

As in: component_match_add() already exists as a macro that calls
component_match_add_release(), but with a NULL release function. If it were
to be changed to pass a default release_of() function then most of the drivers
would not have to change, right? It is just one point of view and I was
curious if there was a reason not to choose it, as it would have (probably)
generated a smaller delta?

If we kept component_match_add() in these drivers, then this patch
would not exist, because there wouldn't be any changes to the drivers.

quoted

Planning to remove it?

Possibly in the longer term, but at the moment there are drivers where
the match data that is passed does not need any release functionality
eg, data allocated with devm_k*alloc(), or

	component_match_add(dev->parent, match, dss_component_compare, dev);

There are some new cases that need converting which have cropped up
during the last merge window, and I expect this to be an on-going
educational point for driver authors, so I'm not too bothered about
capturing all existing cases in this patch.

Understood. Using managed allocators is definitely a strong point in favor
of having the component_match_add() function with a NULL release() hook.

Best regards,
Liviu

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ?\_(?)_/?