Thread (46 messages) 46 messages, 3 authors, 2016-06-29

[RESEND PATCHv2 08/28] ARM: OMAP2+: clockdomain: add usecounting support to autoidle APIs

From: nm@ti.com (Nishanth Menon)
Date: 2016-06-13 23:31:35
Also in: linux-clk, linux-omap

On 06/13/2016 02:04 PM, Tero Kristo wrote:
[..]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-omap2/omap_hwmod.c
b/arch/arm/mach-omap2/omap_hwmod.c
quoted hunk ↗ jump to hunk
index 0c85f91..635a563 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
[...]
quoted hunk ↗ jump to hunk
@@ -2177,14 +2173,10 @@ static int _enable(struct omap_hwmod *oh)
 
 	r = (soc_ops.wait_target_ready) ? soc_ops.wait_target_ready(oh) :
 		-EINVAL;
-	if (!r) {
-		/*
-		 * Set the clockdomain to HW_AUTO only if the target is ready,
-		 * assuming that the previous state was HW_AUTO
-		 */
-		if (oh->clkdm && hwsup)
-			clkdm_allow_idle(oh->clkdm);
+	if (oh->clkdm)
+		clkdm_allow_idle(oh->clkdm);
Should'nt this be under if (!r) ?
 
+	if (!r) {
here?


-- 
Regards,
Nishanth Menon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help