K Kalle Valo #
Message details and related content
Hans de Goede [off-list ref] writes:
Hi, On 30-06-16 11:02, Kalle Valo wrote:quoted
Priit Laes [off-list ref] writes:quoted
quoted
What is the size of this nvram file? As it's board specific, I wonder if we can simply include it inside of the DT verbatim. I remember doing that (in the pre-dtb days, on real open firmware) for the "spidernet" ethernet driver.It contains a bit too much info: This is what CubieTruck requires: http://dl.cubieboard.org/public/Cubieboard/benn/firmware/ap6210/nvram_ap6210.txtIn the nvram file I see lots of identifiers: manfid=0x2d0 prodid=0x492 vendid=0x14e4 devid=0x4343 boardtype=0x0598 boardrev=0x1307 boardnum=777 Are any of these (or a combination of them) unique for each board type? What if one of these is provided through DT and then the driver could choose the nvram file based on the board id? Just another idea...That would require updating a table in the driver every time a new board comes out, I do not believe that that is a good solution.
You don't necessarily need to have a table in the driver if you embed
the id to the filename, for example something like this:
nvram-0598-1307.txt
nvram-<boardtype>-<boardrev>.txt
--
Kalle Valo