[snip]

+

+	return 0;
+
+err2:
+	devm_iounmap(&pdev->dev, bgmac->plat.idm_base);
+err1:
+	devm_iounmap(&pdev->dev, bgmac->plat.base);
+err:
+	devm_kfree(&pdev->dev, bgmac);

This is not needed actually, now that you use the device managed helper
functions.

+
+	return rc;
+}
+
+static int bgmac_remove(struct platform_device *pdev)
+{
+	struct bgmac *bgmac = platform_get_drvdata(pdev);
+
+	bgmac_enet_remove(bgmac);
+	devm_iounmap(&pdev->dev, bgmac->plat.idm_base);
+	devm_iounmap(&pdev->dev, bgmac->plat.base);
+	devm_kfree(&pdev->dev, bgmac);

Same here.
-- 
Florian