Thread (6 messages) 6 messages, 3 authors, 2016-07-01

[PATCH] arm64: dts: rockchip: add the power domain node for rk3399

From: heiko@sntech.de (Heiko Stuebner)
Date: 2016-06-30 22:50:38
Also in: linux-devicetree, linux-rockchip, lkml

Am Donnerstag, 30. Juni 2016, 15:32:01 schrieb Doug Anderson:
Hi,

On Thu, Jun 30, 2016 at 2:57 PM, Heiko Stuebner [off-list ref] wrote:
quoted
quoted
It looks like there are also more power domains that you haven't
listed here (like PD_GMAC, for instance, or PD_CORE_L).  Are you
planning to add those in a followon patch?
that reminds me, nodes with a reg property should have the base address
in the node name as well. Using the constant works nicely, as can be
seen on> 
the rk3288 where we have for example:
        pd_vio at RK3288_PD_VIO
I was wondering about that.  The device tree bindings are similarly
missing the reg from the example.

I'm curious: for sorting purposes, are you supposed to know the
underlying integer and use that for sorting, or sort by the name of
the #define?
requiring the underlying integer sounds very cumbersome, especially as the 
sorting is only a style-thing. So personally I'd take the constants name as 
sorting criteria, as everything else would be somewhat counter-intuitive.

Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help