Thread (17 messages) 17 messages, 5 authors, 2016-06-27

[v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399

From: Guenter Roeck <hidden>
Date: 2016-06-23 17:23:52
Also in: linux-rockchip, lkml

Hi Chris,

[ ... ]
+       ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB,
+                                      &tcphy->event_nb);
+       if (ret) {
+               dev_err(dev, "regitster EXTCON_USB notifer failed\n");
+               return ret;
+       }
+
+       ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB_HOST,
+                                      &tcphy->event_nb);
+       if (ret) {
+               dev_err(dev, "regitster EXTCON_USB_HOST notifer failed\n");
+               return ret;
+       }
+
+       ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_DISP_DP,
+                                      &tcphy->event_nb);
+       if (ret) {
+               dev_err(dev, "regitster EXTCON_DISP_DP notifer failed\n");
+               return ret;
+       }
+
I don't think you can register multiple notifiers with the same
notifier block. It may work by chance, but at least the 'next' object
in notifier_clock is set in notifier_chain_register(). Best case it
may work, but worst case it might cause a loop in the list of
notifiers.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help