[PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

Hi Alexandre & Nicolas,

-----Original Message-----
From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com]
Sent: 2016?6?20? 16:04
To: Yang, Wenyou <redacted>
Cc: Rob Herring <robh@kernel.org>; Alan Stern <stern@rowland.harvard.edu>;
Greg Kroah-Hartman [off-list ref]; Ferre, Nicolas
[off-list ref]; Pawel Moll [off-list ref]; Mark Brown
[off-list ref]; Ian Campbell [off-list ref]; Kumar
Gala [off-list ref]; linux-kernel at vger.kernel.org;
devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
usb at vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB
suspend

On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote :

quoted

quoted

Sure, what I mean is that you can try to get the regmap for the SFR in every

case.

quoted

quoted

Depending on whether you were able to get it, you can decide to call
ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL).

I don't think so. The SFR includes a lot of miscellaneous functions, more than

this one.

quoted

I know but this is irrelevant to this discussion. If you need to use the SFR from
another driver you will simply get it from that other driver.

I that case, you will try to get "atmel,sama5d2-sfr". It is only present on sama5d2
so you have enough information to know whether or not you can use it to
suspend/resume.

I understand what your meaning :).
Use "atmel,sama5d2-sfr" compatible to distinguish whether forcibly suspend USB port via SFR or not.

I am not sure if it is a better solution.

Nicolas, could you give your opinion?

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com

Best Regards,
Wenyou Yang