[alsa-devel] [PATCH v4 3/9] ASoC: mediatek: let mt8173 use mediatek common structure
From: Yingjoe Chen <hidden>
Date: 2016-06-15 10:57:29
Also in:
alsa-devel, linux-mediatek, lkml
On Mon, 2016-06-13 at 15:26 +0800, Garlic Tseng wrote:
quoted hunk ↗ jump to hunk
Modify mt8173 driver implementation to use common structure. Signed-off-by: Garlic Tseng <redacted> --- sound/soc/mediatek/Kconfig | 11 + sound/soc/mediatek/Makefile | 3 +- sound/soc/mediatek/common/Makefile | 17 + sound/soc/mediatek/mt8173/mt8173-afe-common.h | 42 +- sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 679 +++++++++++--------------- 5 files changed, 327 insertions(+), 425 deletions(-) create mode 100644 sound/soc/mediatek/common/Makefilediff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index ae9f664..ff1a419 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig@@ -1,6 +1,16 @@ +config SND_SOC_MEDIATEK + tristate "SND_SOC_MEDIATEK" + depends on ARCH_MEDIATEK + help + This adds ASoC driver for Mediatek boards + that can be used with other codecs. + Select Y if you have such device. + If unsure select "N". + config SND_SOC_MT8173 tristate "ASoC support for Mediatek MT8173 chip" depends on ARCH_MEDIATEK + select SND_SOC_MEDIATEK help This adds ASoC platform driver support for Mediatek MT8173 chip that can be used with other codecs.
It seems both SND_SOC_MT8173 and SND_SOC_MT2701 select SND_SOC_MEDIATEK, and enabling only SND_SOC_MEDIATEK itself is not really useful. Do we need to make SND_SOC_MEDIATEK user configurable option? If it is, we should at least have a proper config prompt instead of just "SND_SOC_MEDIATEK".
quoted hunk ↗ jump to hunk
@@ -49,3 +59,4 @@ config SND_SOC_MT8173_RT5650_RT5676 with the RT5650 and RT5676 codecs. Select Y if you have such device. If unsure select "N". +
nit: This change is not necessary. Joe.C