Thread (7 messages) 7 messages, 3 authors, 2016-06-13

[PATCH 1/3] i.MX: system.c: Convert goto to if statement

From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-06-13 09:23:31
Also in: lkml

On Sunday, June 12, 2016 10:55:27 PM CEST Andrey Smirnov wrote:
Using goto here doesn't bring any advantages and only makes the code
flow less clear. No functional changes.

Signed-off-by: Andrey Smirnov <redacted>
All three patches looks reasonable to me, but now that I looked at
the function, I wonder if we could do another cleanup on top and
not call this function for imx35 at all but instead set the
.l2c_aux_val/.l2c_aux_mask fields in its machine descriptor.

The call to l2x0_of_init(0, ~0) seems to be the only thing we
do on imx35 (where arm,pl310-cache is not present), and the kernel
can do it automatically.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help