On 06/03/2016 11:40 PM, Masami Hiramatsu wrote:

Hi David,

On Thu,  2 Jun 2016 23:26:18 -0400
David Long [off-list ref] wrote:

quoted

From: Pratyush Anand <redacted>

Add all function symbols which are called from do_debug_exception under
NOKPROBE_SYMBOL, as they can not kprobed.

I see, but this patch should be applied after kprobes
are implemented on arm64.

I've gone back to that ordering (I think it was that way in earlier 
versions) but it feels odd.  Wouldn't you want the unsafe symbols marked 
that way before turning on kprobes, like it already is in the generic 
kernel code?

And also, I have a comment below.

quoted

diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 5954881..4359ca8 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c

@@ -563,6 +563,7 @@ asmlinkage void __exception do_sp_pc_abort(unsigned long addr,
  	info.si_addr  = (void __user *)addr;
  	arm64_notify_die("Oops - SP/PC alignment exception", regs, &info, esr);
  }
+NOKPROBE_SYMBOL(do_debug_exception)

This seems at wrong place. Please correct it in this patch.

Fixed.  It was fixed in the next patch but now I've fixed it where it's 
introduced.

Thank you,

Thanks,
-dl