[RFC PATCH 05/15] tty: serial: samsung: fixup accessors for endian
From: Ben Dooks <hidden>
Date: 2016-06-10 10:13:10
Also in:
linux-samsung-soc, linux-serial, lkml
On 08/06/16 19:31, Matthew Leach wrote:
quoted hunk ↗ jump to hunk
Fix the serial access code to deal with kernels built for big endian operation. Signed-off-by: Matthew Leach <redacted> --- CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Jiri Slaby <redacted> CC: linux-serial at vger.kernel.org CC: linux-kernel at vger.kernel.org --- drivers/tty/serial/samsung.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h index fc5deaa..8818bdd 100644 --- a/drivers/tty/serial/samsung.h +++ b/drivers/tty/serial/samsung.h@@ -118,9 +118,9 @@ struct s3c24xx_uart_port { ((unsigned long *)(unsigned long)((port)->membase + (reg))) #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg)))
For completeness we should have changed __raw_readb to readb_relaxed
#define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg))
Acked-by: Ben Dooks <redacted> -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius