Thread (19 messages) 19 messages, 4 authors, 2016-06-03

[PATCH v2 1/7] mdio:mux: Enhanced MDIO mux framework for integrated multiplexers

From: Pramod Kumar <hidden>
Date: 2016-06-03 13:41:49
Also in: linux-devicetree, lkml, netdev

Hi Andrew,
-----Original Message-----
From: Andrew Lunn [mailto:andrew at lunn.ch]
Sent: 01 June 2016 18:32
To: Pramod Kumar
Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala;
Catalin
Marinas; Will Deacon; Kishon Vijay Abraham I; David S. Miller;
devicetree at vger.kernel.org; netdev at vger.kernel.org; linux-
kernel at vger.kernel.org; bcm-kernel-feedback-list at broadcom.com;
linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v2 1/7] mdio:mux: Enhanced MDIO mux framework for
integrated multiplexers
quoted
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index
8453f08..cf40e7a 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -225,6 +225,9 @@ int of_mdiobus_register(struct mii_bus *mdio,
struct
device_node *np)
quoted
 	if (rc)
 		return rc;

+	if (of_property_read_bool(np, "mdio-integrated-mux"))
+		return 0;
+
Hi

Rather than doing this, did you try setting bus->phy_mask = 0 and
calling
mdiobus_register(), rather than of_mdiobus_regsiter() for the parent
bus?
After setting bus->phy_mask = ~0 and using mdiobus_regsiter() I could get
rid of newly added
Property. It works for me as I find same has been done inside of
of_mdiobus_regsiter().

Thanks for pointing out this.
	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help