Thread (112 messages) 112 messages, 9 authors, 2016-05-29
STALE3667d REVIEWED: 1 (0M)

[PATCH kexec-tools 14/32] arm: fix off-by-one on memory end

From: Pratyush Anand <hidden>
Date: 2016-05-25 08:01:12
Also in: kexec

On Tue, May 3, 2016 at 3:52 PM, Russell King [off-list ref] wrote:
The memory range end is inclusive, not exclusive (see x86).  We should
not be adding one to the value parsed from the /proc/iomem resources.

Signed-off-by: Russell King <redacted>
Reviewed-by: Pratyush Anand <redacted>

I think, this also need to be fixed for ARM64 patches. +Geoff
quoted hunk ↗ jump to hunk
---
 kexec/arch/arm/kexec-arm.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/kexec/arch/arm/kexec-arm.c b/kexec/arch/arm/kexec-arm.c
index 4e90e69..e47fc00 100644
--- a/kexec/arch/arm/kexec-arm.c
+++ b/kexec/arch/arm/kexec-arm.c
@@ -51,7 +51,6 @@ int get_memory_ranges(struct memory_range **range, int *ranges,
                if (count != 2)
                        continue;
                str = line + consumed;
-               end = end + 1;

                if (memcmp(str, "System RAM\n", 11) == 0) {
                        type = RANGE_RAM;
--
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help