Thread (1 message) 1 message, 1 author, 2016-05-12

[PATCH 1/4] dt: bindings: add thermal device driver for bcm2835

From: Eric Anholt <hidden>
Date: 2016-05-12 23:03:23
Also in: linux-devicetree, linux-pm

kernel at martin.sperl.org writes:
quoted hunk
From: Martin Sperl <redacted>

Add documentation for bcm2835 SOC thermal sensor.

Signed-off-by: Martin Sperl <redacted>
---
 .../devicetree/bindings/thermal/bcm2835-thermal.txt      | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/bcm2835-thermal.txt
diff --git a/Documentation/devicetree/bindings/thermal/bcm2835-thermal.txt b/Documentation/devicetree/bindings/thermal/bcm2835-thermal.txt
new file mode 100644
index 0000000..607519a
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/bcm2835-thermal.txt
There's a naming convention for the BCM DT bindings these days where you
basically name it after the compatible string, so this file should be
moved to "brcm,bcm2835-thermal.txt" (yes, even though it's inconsistent
with the rest of the files in the directory).
quoted hunk
@@ -0,0 +1,16 @@
+Binding for Thermal Sensor driver for BCM2835 SoCs.
+
+Required parameters:
+-------------------
+
+compatible : 	should be: "brcm,bcm2835-thermal"
Optional: change to 'should be: "brcm,bcm2835-thermal" or
"brcm,bcm2837-thermal"' (see next review for explanation).

I would also drop the space before the colons on the parameters, but as
long as the filename is changed this patch is:

Acked-by: Eric Anholt <redacted>
+reg :		Address range of the thermal registers.
+clocks : 	Phandle of the clock used by the thermal sensor.
+
+Example:
+
+thermal: thermal at 0x7e212000 {
+	compatible = "brcm,bcm2835-thermal";
+	reg = <0x7e212000 0x8>;
+	clocks = <&clocks BCM2835_CLOCK_TSENS>;
+};
-- 
2.1.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160512/f512b792/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help