[PATCH 4/5] coresight: Add better messages for coresight_timeout
From: joe@perches.com (Joe Perches)
Date: 2016-05-31 17:59:06
Also in:
lkml
On Tue, 2016-05-31 at 12:57 +0100, Suzuki K Poulose wrote:
When we encounter a timeout waiting for a status change via coresight_timeout, the caller always print the offset which was tried. This is pretty much useless as it doesn't specify the bit position we wait for. Also, one needs to lookup the TRM to figure out, what was wrong. This patch changes all such error messages to print something more meaningful.
trivia: Perhaps consistently using dev_err(dev, "timeout while waiting for %s\n", "<foo>"); could make the object code a bit smaller.
quoted hunk ↗ jump to hunk
diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
[]
quoted hunk ↗ jump to hunk
@@ -184,8 +184,7 @@ static void etb_disable_hw(struct etb_drvdata *drvdata)? ? if (coresight_timeout(drvdata->base, ETB_FFCR, ETB_FFCR_BIT, 0)) { ? dev_err(drvdata->dev, - "timeout observed when probing at offset %#x\n", - ETB_FFCR); + "timeout while waiting for completion of Manual Flush\n");
ie: dev_err(drvdata->dev, "timeout while waiting for %s\n", "completion of Manual Flush"); but that depends on how many of these coresight files are compiled and linked. There is a while/when usage difference in some of the output messages.