[PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver

From
Carlo Caione <hidden>
Date
2016-05-30 13:51:30
Also in
linux-amlogic, linux-watchdog, lkml
Reply to
Neil Armstrong, 2016-05-30
On 30/05/16 15:29, Neil Armstrong wrote:
Add watchdog specific driver for Amlogic Meson GXBB SoC.

Signed-off-by: Neil Armstrong <redacted>
+
+#define GXBB_WDT_CTRL1_REG			0x4
...
+#define GXBB_WDT_CTRL_EE_RESET_NOW		BIT(26)
...
+#define GXBB_WDT_CTRL_IRQ_EN			BIT(23)
...
+#define GXBB_WDT_CTRL_XTAL_SEL			(0)
...
+#define GXBB_WDT_CTRL_CLK81_SEL			BIT(19)
...
+#define GXBB_WDT_CTRL1_GPIO_PULSE		BIT(17)
...
quoted hunk ↗ jump to hunk
+#define GXBB_WDT_CTRL1_GPIO_POL_RESET_0		BIT(16)
+#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1		(0)
+#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT		(BIT(16) - 1)
nit: all these defines are not used at all in the driver. You can remove them

Thanks!


-- 
Carlo Caione
Thread (12 messages) 12 messages, 4 authors, last reply 2016-06-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help