[PATCH] pinctrl: mediatek: fix dual-edge code defect
From: matthias.bgg@gmail.com (Matthias Brugger)
Date: 2016-05-23 10:39:41
Also in:
linux-devicetree, linux-gpio, lkml
On 21/05/16 09:23, hongkun.cao at mediatek.com wrote:
From: "hongkun.cao" <redacted> When a dual-edge irq is triggered, an incorrect irq will be reported on condition that the external signal is not stable and this incorrect irq has been registered. Correct the register offset.
I'm not sure what you want to say. From what I can see the without this fix, the the wrong IRQ will be cleared and raised. Is this what you are addressing? If so: Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
quoted hunk ↗ jump to hunk
Signed-off-by: hongkun.cao <redacted> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 2bbe6f7..92ae49f 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c@@ -1255,9 +1255,10 @@ static void mtk_eint_irq_handler(struct irq_desc *desc) const struct mtk_desc_pin *pin; chained_irq_enter(chip, desc); - for (eint_num = 0; eint_num < pctl->devdata->ap_num; eint_num += 32) { + for (eint_num = 0; + eint_num < pctl->devdata->ap_num; + eint_num += 32, reg += 4) { status = readl(reg); - reg += 4; while (status) { offset = __ffs(status); index = eint_num + offset;