Thread (12 messages) 12 messages, 3 authors, 2016-05-16

[PATCH V2 2/2] drivers: i2c: qup: Fix error handling

From: Wolfram Sang <hidden>
Date: 2016-05-13 11:50:27
Also in: linux-arm-msm, linux-devicetree, linux-i2c, lkml

On Fri, May 13, 2016 at 01:48:23PM +0200, Wolfram Sang wrote:
On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote:
quoted
Among the bus errors reported from the QUP_MASTER_STATUS register
only NACK is considered and transfer gets suspended, while
other errors are ignored. Correct this and suspend the transfer
for other errors as well. This avoids unnessecary 'timeouts' which
happens when waiting for events that would never happen when there
is already an error condition on the bus.

Signed-off-by: Sricharan R <redacted>
Reviewed-by: Andy Gross <redacted>
Please check Documentation/i2c/fault-codes for proper fault codes.
And while we are here: NACK is not an error but a valid response. Can
you remove the dev_err related to that? Otherwise tools like i2cdetect
will probably flood your log.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160513/9cb5f28c/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help