Thread (18 messages) flat view 18 messages, 4 authors, 2016-04-28
STALE3749d

Revision v2 of 2 in this series.

Revisions (2)
  1. v2 current
  2. v3 [diff vs current]

[PATCH v2 0/2] Control PL310 pwr_ctrl register through DT

From: Brad Mouring <hidden>
Date: 2016-04-18 21:36:49

This submission addresses the concerns brought up here:
http://www.spinics.net/lists/arm-kernel/msg495003.html

The of_property_read_u32 returns -EINVAL when the property is
not found in the dtb, and we ignore that error. An error message
is only printed when the property is present with an invalid value.

The other issue raised was concerning the default behavior if
the properties are not in the dtb. The existing behavior prior
to this changeset is maintained.

During some performance-oriented benchmarking on a Cortex A9
platform, a slight performance degradation was noted on datasets
that spanned into the L2 cache (<10%). This performance hit was
minor, but it prompted investigation into the cause.

One difference in the actual PL310 configuration that was concerning
was the enabling of two PM-related changes: Dynamic Clock Gating
and Standby Mode Enabling. As the kernel being tested was patched
and configured to use the PREEMPT_RT patchset, it was desired to
disable these settings for our use-case since anything PM can
(and usually does) impact determinism.

Making these changes resulted in a modest performance improvement
and those wonderful warm-n-fuzzies regarding determinism and enabling
system control without needing to change the kernel.

In the following set, there's the actual change to control these
features given DT presence of a couple of new bindings and the
documenation to accompany those changes.

Thanks for the feedback!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help