[PATCH v2 1/2] Documentation: DT: vdma: Add clock support for vdma

Hi Rob,

	Thanks for the review...

-----Original Message-----
From: Rob Herring [mailto:robh at kernel.org]
Sent: Saturday, April 23, 2016 1:07 AM
To: Appana Durga Kedareswara Rao <redacted>
Cc: pawel.moll at arm.com; mark.rutland at arm.com;
ijc+devicetree at hellion.org.uk; galak at codeaurora.org; Michal Simek
[off-list ref]; Soren Brinkmann [off-list ref];
vinod.koul at intel.com; dan.j.williams at intel.com; Appana Durga Kedareswara
Rao [off-list ref]; moritz.fischer at ettus.com;
laurent.pinchart at ideasonboard.com; luis at debethencourt.com; Anirudha
Sarangi [off-list ref]; Punnaiah Choudary Kalluri
[off-list ref]; Shubhrajyoti Datta [off-list ref];
devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
kernel at vger.kernel.org; dmaengine at vger.kernel.org
Subject: Re: [PATCH v2 1/2] Documentation: DT: vdma: Add clock support for
vdma

On Wed, Apr 20, 2016 at 05:13:18PM +0530, Kedareswara rao Appana wrote:

quoted

This patch updates the binding doc with clock description for vdma.

Signed-off-by: Kedareswara rao Appana <redacted>
---
Changes for v2:
--> Listed down all the clocks supported by the h/w
    as suggested by the Datta.
--> Used IP clock names instead of shortcut clock names.

 Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8
++++++++
 1 file changed, 8 insertions(+)

diff --git
a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index fcc2b65..afe9eb7 100644

--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt

@@ -21,6 +21,11 @@ Required properties:
 - dma-channel child node: Should have at least one channel and can have up

to

quoted

 	two channels per device. This node specifies the properties of each
 	DMA channel (see child node properties below).
+- clocks: Input clock specifier. Refer to common clock bindings.
+- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk"
+	       "m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk"
+	       (list of input cloks may vary based on the ip configuration.

s/cloks/clocks/

quoted

+		see clock bindings for more info).

This does not make sense. The common clock binding is going to tell me more
about how the clocks vary?

I have fixed these comments in the other version (v4) you acked that patch...

Regards,
Kedar.

You need to define here how the clocks can vary.