On 08.04.2016 19:46, Sinan Kaya wrote:

Hi Tomasz,

On 4/8/2016 2:51 AM, Tomasz Nowicki wrote:

quoted

Hi Sinan,

On 08.04.2016 05:40, Sinan Kaya wrote:

quoted

Hi Tomasz,

On 4/7/2016 5:41 PM, Bjorn Helgaas wrote:

quoted

quoted

quoted

You say this is undoing the effect of pci_remap_iospace(), but that's

quoted

quoted

only called by native drivers and the generic (OF) driver, not by
pci_root.c.

See the ACPI root bridge driver above.

If this is a fix to patches that haven't been merged yet, we need to
squash the fix into the patches.

Can you merge these to two patches to your series for the next post?

I need to remove weak on the first patch per direction from Bjorn and
fix the function comments. You could as well do this while you are merging.

Let me know what your preference is.

Please do necessary fixes for your patches and send me the repo reference link. I will merge these to my patch set. Thanks!

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

I posted the updated patch here. Changes are:

- I squashed these two patches together per Bjorn's request.
- Removed the weak declarations from both remap and unmap calls.
- Fixed the doxygen document to match the actual parameters.

https://us.codeaurora.org/cgit/quic/server/kernel/commit/?h=okaya/pciunmapv2&id=6120a5f0c5e6d757f18a076917fa202e2c9823d0

Thanks Sinan!

Tomasz