[PATCH 1/2] clk: bcm2835: expose raw clock-registers via debugfs
From: Eric Anholt <hidden>
Date: 2016-03-01 18:41:40
Also in:
linux-clk
Martin Sperl [off-list ref] writes:
On 29.02.2016 21:39, Eric Anholt wrote:quoted
kernel at martin.sperl.org writes:quoted
From: Martin Sperl <redacted> For debugging purposes under some circumstance it helps to be able to see the actual clock registers. E.g: when looking at the clock divider it is helpful to see what the actual clock divider is. This patch exposes all the clock registers specific to each clock/pll/pll-divider via debugfs. Signed-off-by: Martin Sperl <redacted>This one definitely seems useful to me. I think the debugfs bits need to be under #ifdef CONFIG_DEBUG_FS though. With that fixed, Acked-by: Eric Anholt <redacted>Note that include/linux/debugfs.h contains such ifdef and generates dummy code like this: static inline struct dentry *debugfs_create_regset32(const char *name, umode_t mode, struct dentry *parent, struct debugfs_regset32 *regset) { return ERR_PTR(-ENODEV); } (see also Documentation/filesystem/debugfs.txt )
OK, looks like the CONFIG_DEBUG_FS ifdefs I've seen in other drivers are just noise. The patch should be good as-is, then. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160301/cbbb2f9d/attachment.sig>