[RFC PATCH 1/3] libahci: save port map for forced port map
From: tj@kernel.org (Tejun Heo)
Date: 2016-03-30 18:57:12
Also in:
linux-arm-msm, linux-devicetree, linux-ide, lkml
Hello, On Tue, Mar 29, 2016 at 02:11:13PM +0100, Srinivas Kandagatla wrote:
quoted hunk ↗ jump to hunk
In usecases where force_port_map is used saved_port_map is never set, resulting in not programming the PORTS_IMPL register as part of intial config. This patch fixes this by setting it to port_map even in case where force_port_map is used, making it more inline with other parts of the code. Signed-off-by: Srinivas Kandagatla <redacted> --- drivers/ata/libahci.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 3982054..a5d7c1c 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c@@ -507,6 +507,7 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv) dev_info(dev, "forcing port_map 0x%x -> 0x%x\n", port_map, hpriv->force_port_map); port_map = hpriv->force_port_map; + hpriv->saved_port_map = port_map;
So, the only change it'd cause is making the driver write the forced value to the PI register. Does that make sense? Thanks. -- tejun