[PATCH v2 6/8] drm/fsl-dcu: add TCON driver
From: Alexander Stein <hidden>
Date: 2016-03-29 06:45:43
Also in:
dri-devel, linux-devicetree, lkml
Hi, some comments below. On Monday 28 March 2016 19:00:00, Stefan Agner wrote:
Add driver for the TCON (timing controller) module. The TCON module is a separate module attached after the DCU (display controller unit). Each DCU instance has its own, directly connected TCON instance. The DCU's RGB and timing signals are passing through the TCON module. TCON can provide timing signals for raw TFT panels or operate in a bypass mode which leaves all signals unaltered. The driver currently only supports the bypass mode. Signed-off-by: Stefan Agner <stefan@agner.ch>
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/display/fsl,dcu.txt +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt@@ -14,6 +14,7 @@ Required properties: Optional properties: - clocks: Second handle for pixel clock. - clock-names: Second name "pix" for pixel clock. +- fsl,tcon: The phandle to the timing controller node.
Maybe a comment this is (currently) only for Vybrid, but not LS1021A.
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c[...] +struct fsl_tcon *fsl_tcon_init(struct device *dev) +{ + struct fsl_tcon *tcon; + struct device_node *np; + int ret; + + tcon = devm_kzalloc(dev, sizeof(*tcon), GFP_KERNEL); + if (!tcon) + return NULL; + + np = of_parse_phandle(dev->of_node, "fsl,tcon", 0); + if (!np) { + dev_warn(dev, "Couldn't find the tcon node\n"); + return NULL; + }
Maybe check for device tree node before allocating struct fsl_tcon? Also this should not be a warning, as on LS1021A this is to be expected. Best regards, Alexander