Thread (14 messages) 14 messages, 6 authors, 2016-03-30

[PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity

From: tharvey@gateworks.com (Tim Harvey)
Date: 2016-03-28 20:42:36
Also in: linux-pci, lkml

On Mon, Mar 28, 2016 at 1:13 PM, Fabio Estevam [off-list ref] wrote:
Hi Tim,

On Mon, Mar 28, 2016 at 4:59 PM, Tim Harvey [off-list ref] wrote:
quoted
Fabio,

I would agree with you on this - 5c5fb40de8f143 ("PCI: imx6: Add
support for active-low reset GPIO")  should be reverted.

I just finished bisecting an issue to this specific patch only to find
out Krzysztof found it a few days ago ;) Thanks Krzysztof.
I sent the revert patch yesterday:
http://marc.info/?l=linux-pci&m=145912622805757&w=2
Fabio,

ok - I'll respond there as I agree with the patch but not the wording
of the commit (It's Gateworks 'Ventana' using IMX6 not Laguna and we
do define the polarity properly as active-low in Ventana dt's). It is
the fact that the gpio polarity has the wrong logic level that breaks
Ventana.

However, there seems to be another regression in 4.5 that's keeping
PCI working for me and I'm still bisecting that (using 802.11n access
points to test). Can you confirm that PCI works in v4.5 on IMX6 boards
with only 5c5fb40de8f14391a1238db05cef88754faf9229 reverted?

Tim
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help