Thread (19 messages) 19 messages, 5 authors, 2016-03-31

[RFC5 PATCH v6 00/21] ILP32 for ARM64

From: Zhangjian Bamvor <hidden>
Date: 2016-03-26 13:17:31
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Hi, Yury

On 2016/3/22 2:40, Yury Norov wrote:
On Mon, Mar 21, 2016 at 10:07:49AM +0100, Andreas Schwab wrote:
[...]
Hi Andreas,

Thank you for your patch. It seems like it fixed a couple of tests.
I applied it to the library branch. Current list of fails is like this:
float_bessel                   FAIL       137
float_exp_log                  FAIL       137
float_iperb                    FAIL       137
float_power                    FAIL       137
float_trigo                    FAIL       137
pipeio_3                       FAIL       5
abort01                        FAIL       2
clone02                        FAIL       4
kill10                         FAIL       2
kill11                         FAIL       2
mmap16                         FAIL       6
nftw01                         FAIL       1
nftw6401                       FAIL       1
open12                         FAIL       2
pathconf01                     FAIL       1
profil01                       FAIL       1
rename11                       FAIL       2
rmdir02                        FAIL       2
umount2_01                     FAIL       2
umount2_02                     FAIL       2
umount2_03                     FAIL       2
utime06                        FAIL       2
mtest06                        FAIL       11
This is a patch for glibc.
I found 64bit register is used in sysdep.h. It could fix some failure
in bigendian. I do not test it on little endian yet. Hope It helps.

Regards

Bamvor
 From a4af2b7a8903ac5e033ba838ec3328bdeb1113ba Mon Sep 17 00:00:00 2001
From: Yang Yingliang <redacted>
Date: Thu, 13 Nov 2014 16:05:58 +0800
Subject: [PATCH] ARM64: ILP32: change register x1 to PTR_REG

It should use 32-bit register instead of 64-bit register in ILP32.

Suggested-by: Andrew Pinski <redacted>
Signed-off-by: Yang Yingliang <redacted>
Signed-off-by: Bamvor Jian Zhang <redacted>
---
  sysdeps/aarch64/sysdep.h                 | 2 +-
  sysdeps/unix/sysv/linux/aarch64/sysdep.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
index 6673242..742d23c 100644
--- a/sysdeps/aarch64/sysdep.h
+++ b/sysdeps/aarch64/sysdep.h
@@ -104,7 +104,7 @@
  #define LDST_GLOBAL(OP, R, T,  EXPR)			\
  	adrp	x##T, :got:EXPR;			\
  	ldr	PTR_REG (T), [x##T, #:got_lo12:EXPR];	\
-	OP	x##R, [x##T];
+	OP	PTR_REG (R), [x##T];

  /* Since C identifiers are not normally prefixed with an underscore
     on this system, the asm identifier `syscall_error' intrudes on the
diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
index 2bfec77..8fb8a6b 100644
--- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h
+++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
@@ -108,7 +108,7 @@
  .Lsyscall_error:						\
  	adrp	x1, :gottprel:errno;				\
  	neg	w2, w0;						\
-	ldr	x1, [x1, :gottprel_lo12:errno];			\
+	ldr	PTR_REG(1), [x1, :gottprel_lo12:errno];		\
  	mrs	x3, tpidr_el0;					\
  	mov	x0, -1;						\
  	str	w2, [x1, x3];					\
-- 
1.8.4.5


> Yury.
>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help