[PATCH v5 5/9] dmaengine: rcar-dmac: slave address are physical
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
Date: 2016-03-17 16:43:31
Also in:
linux-arch, linux-iommu, linux-renesas-soc, lkml
Hi Niklas, Thank you for the patch. On Tuesday 08 March 2016 03:42:50 Niklas S?derlund wrote:
quoted hunk ↗ jump to hunk
Slave addresses coming from a client is physical not dma. Store the address using the correct data type. This is in preparation for hooking up the dma-mapping API to the slave addresses. Signed-off-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/dma/sh/rcar-dmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index 7820d07..01cf82f 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c@@ -144,8 +144,8 @@ struct rcar_dmac_chan { unsigned int src_xfer_size; unsigned int dst_xfer_size; - dma_addr_t src_slave_addr; - dma_addr_t dst_slave_addr; + phys_addr_t src_slave_addr; + phys_addr_t dst_slave_addr;
This moves the cast from phys_addr_t to dma_addr_t from the driver's DMA engine operations to other places. I'm not sure there's much value in doing so. I'd squash this patch with 7/9, the result will be easier to review.
int mid_rid; spinlock_t lock;
-- Regards, Laurent Pinchart