Thread (42 messages) 42 messages, 5 authors, 2016-03-03

[rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

From: Krzysztof Kozłowski <hidden>
Date: 2016-03-03 12:33:32
Also in: linux-arm-msm, linux-gpio, linux-media, linux-pm, linux-rtc, linux-samsung-soc, lkml, netdev

2016-03-03 21:28 GMT+09:00 Arnd Bergmann [off-list ref]:
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
quoted
quoted
Not user visible.
Hmmm... you are right (here and in other patches) but why am I getting
all these errors:
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
&& DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI &&
TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM
&& ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which
has unmet direct dependencies (HAS_IOMEM)
?
(ARCH=um, allyesconfig)
The problem is that Kconfig will just print any option that
selects the one that has a missing dependency, but doesn't
show which of those are actually enabled.
Indeed... but apparently putting direct HAS_IOMEM dependency on these
symbols silences the Kconfig warning.
quoted
Adding depends here (and in other places) really helps... but it
should not have any impact...
I think patch 5 by itself would have been sufficient.
Thanks for analysis. Since all patches are independent (and IMHO the
last one is not needed really) so I won't resend the patchset. Instead
let maintainer pick what is meaningful.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help