Thread (3 messages) 3 messages, 3 authors, 2016-02-17
DORMANTno replies

[PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode

From: davem@davemloft.net (David Miller)
Date: 2016-02-17 15:51:04
Also in: linux-omap, netdev

From: "David Rivshin (Allworx)" <redacted>
Date: Fri, 12 Feb 2016 19:45:36 -0500
From: David Rivshin <redacted>

The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
and silently handled any other values as if MII was specified. In a
case where the PHY mode was incorrectly specified, or a bug elsewhere,
there would be no indication of a problem. If MII was the correct mode,
then this will go unnoticed, otherwise the symptom will be a failure
to transmit/receive data over the RMII/RGMII link.

Add a dev_warn() to make this condition obvious and provide a
breadcrumb to follow.

Cc: Mugunthan V N <redacted>
Signed-off-by: David Rivshin <redacted>
Applied to 'net', thanks.  I don't think I'll queue this up for -stable.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help