Thread (9 messages) 9 messages, 4 authors, 2016-02-22

GPIO regression in Linux next caused by syscon change

From: tony@atomide.com (Tony Lindgren)
Date: 2016-02-15 16:47:57
Also in: linux-omap

* Philipp Zabel [off-list ref] [160215 08:17]:
Am Montag, den 15.02.2016, 08:01 -0800 schrieb Tony Lindgren:
quoted
* Philipp Zabel [off-list ref] [160214 11:24]:
quoted
I've just replaced the of_iomap() call with an open coded version,
calling of_address_to_resource() and ioremap() directly. That was
needed so I can use the struct resource returned by
of_address_to_resource() to set the syscon_config.max_register. I
don't see where this could cause resource overlap. Does just setting
syscon_config.max_register to zero again make the problem disappear?
Yes commenting out the syscon_config.max_register line in your patch
makes things work again.

So what does that tell us about the problem?
Maybe some out of bounds writes that previously worked are now catched
by the max_register check in regmap_writable and regmap_write returns
-EIO instead of the write being executed.
Hmm weird that something like that would not produce errors?
Is there any omap_ctrl_write?() call with an offset > 0x32c into
scm_conf?
Indeed, that's where things go wrong. Adding Tero to Cc, something
is wrong there.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help