Thread (8 messages) 8 messages, 4 authors, 2016-02-13

[PATCH v2] pinctrl: mvebu: fix num_settings in mpp group assignment

flat view
DORMANTno replies

From: Linus Walleij <hidden>
Date: 2016-02-13 22:52:42

On Mon, Feb 1, 2016 at 11:48 PM, Sebastian Hesselbarth
[off-list ref] wrote:
When assigning mpp settings from static mpp modes to mpp groups,
we do not want any groups that have no supported setting for a
specific Kirkwood variant. However, when there is at least a
single supported setting, we need to assign the number of all
settings in this mode to grp->num_settings as we are reusing
the static modes table.

Fixes: 0581b16b1840 ("pinctrl: mvebu: complain about missing group after checking variant")
Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
--
Changelog:
v1->v2:
- Chose a less intrusive fix by adding supp_settings variable
  instead of looping over the settings twice.
Patch applied with Aaro's Test tag.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help