Thread (15 messages) 15 messages, 4 authors, 2016-02-08

[PATCH v3 3/3] reset: Add support for shared reset controls

flat view
STALE3900d SUPERSEDED

From: Hans de Goede <hidden>
Date: 2016-02-05 18:28:45

Revision v3 of 10 in this series.

Revisions (10)
  1. v3
  2. v3
  3. v3
  4. v3
  5. v3
  6. v3
  7. v3
  8. v3
  9. v3 current
  10. v4 [diff vs current]
Hi,

On 05-02-16 10:08, Philipp Zabel wrote:
Am Mittwoch, den 27.01.2016, 19:15 +0100 schrieb Hans de Goede:
[...]
quoted
@@ -94,9 +99,16 @@ EXPORT_SYMBOL_GPL(reset_controller_unregister);
  /**
   * reset_control_reset - reset the controlled device
   * @rstc: reset controller
+ *
+ * Calling this on a shared reset controller is an error.
   */
  int reset_control_reset(struct reset_control *rstc)
  {
+	if (rstc->shared) {
+		WARN_ON(1);
+		return -EINVAL;
Occurrences of
	if (condition) {
		WARN_ON(1);
		...
	}
could be changed to
	if (WARN_ON(condition)) {
		...
	}
Good one, will fix for v4 (v2 of the second attempt at this).

Regards,

Hans
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help