Thread (11 messages) flat view 11 messages, 2 authors, 2016-02-03
STALE3859d

Revision v1 of 8 in this series.

Revisions (8)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 current
  4. v1 [diff vs current]
  5. v2 [diff vs current]
  6. v2 [diff vs current]
  7. v2 [diff vs current]
  8. v2 [diff vs current]

[PATCH v1 2/5] arm64: add ARMv8.2 id_aa64mmfr2 boiler plate

From: james.morse@arm.com (James Morse)
Date: 2016-02-03 15:31:00

Hi Suzuki,

On 03/02/16 12:12, Suzuki K. Poulose wrote:
On 02/02/16 17:03, James Morse wrote:
quoted
ARMv8.2 adds a new feature register id_aa64mmfr2. This patch adds the
cpu feature boiler plate used by the actual features in later patches.

Signed-off-by: James Morse <james.morse@arm.com>
quoted
  #define SYS_CNTFRQ_EL0            sys_reg(3, 3, 14, 0, 0)
  #define SYS_CTR_EL0            sys_reg(3, 3, 0, 0, 1)
diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index a84febc40db2..a4f665f95f9f 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -123,6 +123,10 @@ static struct arm64_ftr_bits ftr_id_aa64mmfr1[] = {
      ARM64_FTR_END,
  };

+static struct arm64_ftr_bits ftr_id_aa64mmfr2[] = {
+    ARM64_FTR_END,
It will be good to see all the defined fields in id_aa64mmfr2 added here in
this patch. You could also move the definition of UA0 field from the next patch
to here.
Okay, what are the rules for unsupported features?

UAO support isn't added until a later patch, I assumed it was best to add the
definition as part of that patch.
Otherwise looks good.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Thanks,

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help