Thread (7 messages) 7 messages, 6 authors, 2016-03-03

[PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

From: festevam@gmail.com (Fabio Estevam)
Date: 2016-02-29 21:16:50
Also in: linux-crypto, linux-devicetree

On Mon, Feb 29, 2016 at 12:52 PM, Steffen Trumtrar
[off-list ref] wrote:
+       ret = clk_prepare_enable(rngc->clk);
+       if (ret)
+               return ret;
+
+       rngc->irq = platform_get_irq(pdev, 0);
+       if (!rngc->irq) {
+               dev_err(&pdev->dev, "FSL RNGC couldn't get irq\n");
+               clk_disable_unprepare(rngc->clk);
+
+               return ret;
You are returning the wrong error code here:

Better do like this:

       rngc->irq = platform_get_irq(pdev, 0);
       if (rngc->irq < 0) {
               dev_err(&pdev->dev, "FSL RNGC couldn't get irq\n");
               clk_disable_unprepare(rngc->clk);
               return rngc->irq;
       }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help