[PATCH v3 1/2] ehci-platform: Add support for controllers with multiple reset lines

On Wed, 24 Feb 2016, Roger Quadros wrote:

Hi,

On 24/02/16 13:15, Hans de Goede wrote:

quoted

From: Reinder de Haan <redacted>

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple
reset lines, the controller will not initialize while the reset for
its companion is still asserted, which means we need to de-assert
2 resets for the controller to work.

Signed-off-by: Reinder de Haan <redacted>
Signed-off-by: Hans de Goede <redacted>

quoted

-	} else {
-		err = reset_control_deassert(priv->rst);
-		if (err)
-			goto err_put_clks;
+		for (rst = 0; rst < EHCI_MAX_RESETS; rst++) {
+			priv->resets[rst] =
+				devm_reset_control_get_shared_by_index(
+								&dev->dev, rst);

Ugly continuation line.  The convention in these files is to indent 
continuation lines by two tab stops beyond the original source line.
Same comment applies to the 2/2 patch.

Once that is changed, you can add:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

to both.

Alan Stern