Thread (96 messages) 96 messages, 27 authors, 2016-04-20

[PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2016-02-24 13:59:48
Also in: linux-gpio, linux-mediatek, linux-renesas-soc, lkml

Hi Laxman,

On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan [off-list ref] wrote:
Use devm_pinctrl_register() for pin control registration.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc at vger.kernel.org
Thanks for your patch!
quoted hunk ↗ jump to hunk
index 87b0a59..f17b5fc 100644
--- a/drivers/pinctrl/sh-pfc/pinctrl.c
+++ b/drivers/pinctrl/sh-pfc/pinctrl.c
@@ -692,19 +692,9 @@ int sh_pfc_register_pinctrl(struct sh_pfc *pfc)
        pmx->pctl_desc.pins = pmx->pins;
        pmx->pctl_desc.npins = pfc->info->nr_pins;

-       pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);
+       pmx->pctl = devm_pinctrl_register(pfc->dev, &pmx->pctl_desc, pmx);
        if (IS_ERR(pmx->pctl))
                return PTR_ERR(pmx->pctl);

        return 0;
 }
-
-int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc)
-{
-       struct sh_pfc_pinctrl *pmx = pfc->pinctrl;
-
-       pinctrl_unregister(pmx->pctl);
-
-       pfc->pinctrl = NULL;
-       return 0;
-}
There's no longer a need to have sh_pfc.pinctrl, so please remove that field
while you're at it.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help