[PATCH] bus: imx-weim: Take the 'status' property value into account
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2016-02-23 08:57:48
Also in:
lkml, stable
On Mon, Feb 22, 2016 at 09:01:53AM -0300, Fabio Estevam wrote:
From: Fabio Estevam <redacted>
Currently we have an incorrect behaviour when multiple devices
are present under the weim node. For example:
&weim {
...
status = "okay";
sram at 0,0 {
...
status = "okay";
};
mram at 0,0 {
...
status = "disabled";
};
};
In this case only the 'sram' device should be probed and not 'mram'.
However what happens currently is that the status variable is ignored,
causing the 'sram' device to be disabled and 'mram' to be enabled.
Change the weim_parse_dt() function to use
for_each_available_child_of_node()so that the devices marked with
'status = disabled' are not probed.
Cc: <redacted>
Suggested-by: Wolfgang Netbal <redacted>
Signed-off-by: Fabio Estevam <redacted>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Seems to be the right thing to do. Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha
quoted hunk ↗ jump to hunk
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index e98d15e..1827fc4 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c@@ -150,7 +150,7 @@ static int __init weim_parse_dt(struct platform_device *pdev, return ret; } - for_each_child_of_node(pdev->dev.of_node, child) { + for_each_available_child_of_node(pdev->dev.of_node, child) { if (!child->name) continue;-- 1.9.1
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |