Thread (19 messages) 19 messages, 2 authors, 2016-02-22

[PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

flat view

From: mark.rutland@arm.com (Mark Rutland)
Date: 2016-02-22 15:16:29
Also in: lkml

A couple more comments for things i just realised:
quoted hunk ↗ jump to hunk
+	/*
+	 * Now that all the counters are disabled, we can safely turn the PMU on,
+	 * without syncing the status of the counters
+	 */
+	__cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);
As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]
+		pmu_write_counter(cci_pmu,
+				  (u32)local64_read(&event->hw.prev_count), i);
That cast can go.

Mark.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help