On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:

I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
the compatible like:
- compatible: should be one of the followings
   - "rockchip,rk3066-i2s": for rk3066
   - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
   - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
   - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
and the driver only has
static const struct of_device_id rockchip_i2s_match[] = {
	{ .compatible = "rockchip,rk3066-i2s", },
	{},
};

The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
keep different rules ?

No, that's just something that got missed in review and which should be
fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160218/6cb04dc6/attachment.sig>