[PATCH 2/2] ARM: mm: hide __start_rodata_section_aligned for non-debug builds

On 16 February 2016 at 17:34, Arnd Bergmann [off-list ref] wrote:

On Tuesday 16 February 2016 17:12:52 Ard Biesheuvel wrote:

quoted

quoted

+#ifdef CONFIG_DEBUG_RODATA
 /*
  * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
  * be the first section-aligned location after __start_rodata. Otherwise,
  * it will be equal to __start_rodata.
  */
 __start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
+#endif

Does

PROVIDE(__start_rodata_section_aligned = xxx);

do the trick as well? If it does, it's a bit cleaner.

I would assume not, as the problem is that SECTION_SHIFT is a macro that
is not defined when the MMU is disabled.

I just tested it myself, and it in fact does work.

PROVIDE() means the expression is evaluated lazily, and SECTION_SHIFT
is just an undefined identifier in the linker script scope if the
preprocessor does not define it.

Anyway, I don't have a strong preference, so ack either way.