On Wednesday, January 20, 2016 05:12:18 PM Andy Shevchenko wrote:

On Wed, Jan 20, 2016 at 4:29 PM, Aleksey Makarov
[off-list ref] wrote:

quoted

Factor out the code that finds the first physical device
of a given ACPI device.  It is used in several places.

Reviewed-by: Andy Shevchenko <redacted>
Signed-off-by: Aleksey Makarov <redacted>

Hmm? Sorry, didn't notice one style issue and there is one is matter
of taste below.

quoted

--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c

@@ -43,7 +43,6 @@ static const struct acpi_device_id forbidden_id_list[] = {

quoted

+       pdevinfo.parent = adev->parent ?
+               acpi_get_first_physical_node(adev->parent) : NULL;

Matter of taste, but I believe if-else looks better here even when
consumes +2 LOC.

I disagree.

Thanks,
Rafael