[PATCH 4/4] dmaengine: pxa_dma: fix the maximum requestor line
From: Vinod Koul <hidden>
Date: 2016-02-15 16:31:39
Also in:
linux-devicetree, lkml
On Thu, Feb 11, 2016 at 10:23:18PM +0100, Robert Jarzmik wrote:
quoted hunk ↗ jump to hunk
@@ -1399,13 +1405,17 @@ static int pxad_probe(struct platform_device *op) return PTR_ERR(pdev->base); of_id = of_match_device(pxad_dt_ids, &op->dev); - if (of_id) + if (of_id) { of_property_read_u32(op->dev.of_node, "#dma-channels", &dma_channels); - else if (pdata && pdata->dma_channels) + of_property_read_u32(op->dev.of_node, "#requestors", + &nb_requestors);
I think we should check the return value here. This might be err in case when we have older DT on platform, but still should work with default in that case
+ } else if (pdata && pdata->dma_channels) {
dma_channels = pdata->dma_channels;
- else
+ nb_requestors = pdata->nb_requestors;
+ } else {
dma_channels = 32; /* default 32 channel */
+ }-- ~Vinod