Thread (22 messages) 22 messages, 2 authors, 2016-02-17

[PATCH V5 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback

From: John Crispin <hidden>
Date: 2016-02-14 21:02:06
Also in: linux-mediatek, lkml


On 11/02/2016 12:54, Matthias Brugger wrote:
quoted
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
b/drivers/soc/mediatek/mtk-pmic-wrap.c
index b22b664..e3bbee5 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -372,6 +372,7 @@ struct pmic_wrapper_type {
      enum pwrap_type type;
      u32 arb_en_all;
      int (*init_reg_clock)(struct pmic_wrapper *wrp);
+    int (*init_special)(struct pmic_wrapper *wrp);
Nit:
I wonder if we can find a better name for the callback, as init_special
sounds quite generic to me.

Thanks,
Matthias
Hi,

At first I considered enable_wrapper as the mt8135/8173 code seems to do
just that. however mt2701 does an init of the ADC. So how about using
init_soc_specific ?

	John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help