Thread (13 messages) 13 messages, 7 authors, 2016-02-12

[PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

From: robh+dt@kernel.org (Rob Herring)
Date: 2016-02-11 23:15:51
Also in: linux-devicetree, lkml, stable

On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier [off-list ref] wrote:
On 09/02/16 11:04, Robin Murphy wrote:
quoted
The existing msi-map code is fine for shifting the entire RID space
upwards, but attempting finer-grained remapping reveals a bug. It turns
out that we are mistakenly treating the msi-base part as an offset, not
as a new base to remap onto, so things get squiffy when rid-base is
nonzero. Fix this, and at the same time add a sanity check against
having msi-map-mask clash with a nonzero rid-base, as that's another
thing one can easily get wrong.

CC: <redacted>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Rob, Frank,

Are you willing to take this one through the OF tree? Or should we route
it through the IRQ tree? It'd be good if it make it into 4.5.
Applied for 4.5. ATM, I don't have anything else to send to Linus.
I'll give it a week or so if this is not urgent. Or send me a bunch of
DT binding fixes and you can get it in sooner. ;)

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help