Thread (26 messages) 26 messages, 6 authors, 2016-02-25

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

From: Linus Walleij <hidden>
Date: 2016-02-11 13:50:45
Also in: linux-gpio, lkml

On Thu, Feb 11, 2016 at 2:20 PM, Krzysztof Adamski [off-list ref] wrote:
On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote:
quoted
On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski [off-list ref] wrote:
quoted
sunxi_pmx_set accepts pin number and then calculates offset by
subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
gets offset so we have to convert it to pin number so we won't get
negative value in sunxi_pmx_set.

This was only used on A10 so far, where there is only one GPIO chip with
pin_base set to 0 so it didn't matter. However H3 also requires this
workaround but have two pinmux sections, triggering problem for PL port.

Signed-off-by: Krzysztof Adamski <redacted>

Waiting for Maxime to review this. I guess this patch can be merged
independently of the other patches?
Yes it can but it won't have any effect, as stated in the commit message,
since other SoCs either don't use this flag or have only one port so theri
pin_base=0.
Who cares as long as it will be used eventually.

Merged v4 as stated earlier.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help